From 34570f3834d5a5a40397b3aa8a7a3c178aa34dc2 Mon Sep 17 00:00:00 2001
From: Davide Tantillo <iamdjj@gmail.com>
Date: Tue, 16 Sep 2025 12:33:52 +0200
Subject: [PATCH] [ts][pixi-v8] Slot objects are rendered only if skipRender is
 false. See #2919.

---
 spine-ts/spine-pixi-v8/src/SpinePipe.ts | 23 ++++++++++++++---------
 1 file changed, 14 insertions(+), 9 deletions(-)

diff --git a/spine-ts/spine-pixi-v8/src/SpinePipe.ts b/spine-ts/spine-pixi-v8/src/SpinePipe.ts
index cd0242904..44f71c1a8 100644
--- a/spine-ts/spine-pixi-v8/src/SpinePipe.ts
+++ b/spine-ts/spine-pixi-v8/src/SpinePipe.ts
@@ -27,17 +27,17 @@
  * THE SPINE RUNTIMES, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  *****************************************************************************/
 
+import { MeshAttachment, RegionAttachment } from '@esotericsoftware/spine-core';
 import {
-	extensions, ExtensionType,
-	InstructionSet,
 	type BLEND_MODES,
-	type Container,
+	type Container, ExtensionType,
+	extensions,
+	type InstructionSet,
 	type Renderer,
 	type RenderPipe,
 } from 'pixi.js';
 import { BatchableSpineSlot } from './BatchableSpineSlot.js';
-import { Spine } from './Spine.js';
-import { MeshAttachment, RegionAttachment } from '@esotericsoftware/spine-core';
+import type { Spine } from './Spine.js';
 
 const spineBlendModeMap: Record<number, BLEND_MODES> = {
 	0: 'normal',
@@ -123,6 +123,7 @@ export class SpinePipe implements RenderPipe<Spine> {
 			const slot = drawOrder[i];
 			const attachment = slot.getAttachment();
 			const blendMode = spineBlendModeMap[slot.data.blendMode];
+			let skipRender = false;
 
 			if (attachment instanceof RegionAttachment || attachment instanceof MeshAttachment) {
 				const cacheData = spine._getCachedData(slot, attachment);
@@ -135,7 +136,8 @@ export class SpinePipe implements RenderPipe<Spine> {
 					roundPixels
 				);
 
-				if (!cacheData.skipRender) {
+				skipRender = cacheData.skipRender;
+				if (!skipRender) {
 					batcher.addToBatch(batchableSpineSlot, instructionSet);
 				}
 			}
@@ -145,9 +147,12 @@ export class SpinePipe implements RenderPipe<Spine> {
 			if (containerAttachment) {
 				const container = containerAttachment.container;
 
-				container.includeInBuild = true;
-				// See https://github.com/pixijs/pixijs/blob/b4c050a791fe65e979e467c9cba2bda0c01a1c35/src/scene/container/utils/collectAllRenderables.ts#L28
-				container.collectRenderables(instructionSet, this.renderer, null!);
+				if (!skipRender) {
+					container.includeInBuild = true;
+					// See https://github.com/pixijs/pixijs/blob/b4c050a791fe65e979e467c9cba2bda0c01a1c35/src/scene/container/utils/collectAllRenderables.ts#L28
+					container.collectRenderables(instructionSet, this.renderer, null!);
+				}
+
 				container.includeInBuild = false;
 			}
 		}