UnityMirror/spine-runtimes
1
0
Fork 0
mirror of https://github.com/EsotericSoftware/spine-runtimes.git synced 2025-12-21 01:36:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix warning: suggest parentheses around comparison in operand of ‘!=’ (#2721)

Browse Source 
spine-c/spine-c/src/spine/Bone.c: In function ‘spBone_updateWorldTransformWith’:
spine-c/spine-c/src/spine/Bone.c:169:64: warning: suggest parentheses around comparison in operand of ‘!=’ [-Wparentheses]
  169 |                                 (pa * pd - pb * pc < 0) != (sx < 0 != sy < 0))
      |                                                             ~~~^~~
spine-c/spine-c/src/spine/Bone.c: In function ‘spBone_updateAppliedTransform’:
spine-c/spine-c/src/spine/Bone.c:284:76: warning: suggest parentheses around comparison in operand of ‘!=’ [-Wparentheses]
  284 |                                         pid < 0 != (self->skeleton->scaleX < 0 != (self->skeleton->scaleY * yDownScale) < 0))
      |                                                     ~~~~~~~~~~~~~~~~~~~~~~~^~~
spine-c/spine-c/src/spine/Bone.c:284:45: warning: suggest parentheses around comparison in operand of ‘!=’ [-Wparentheses]
  284 |                                         pid < 0 != (self->skeleton->scaleX < 0 != (self->skeleton->scaleY * yDownScale) < 0))
      |                                         ~~~~^~~
This commit is contained in:
Jan Niklas Hasse 2025-02-11 14:16:20 +01:00 committed by GitHub
parent 43b9f6cab3
commit b9abc0c5b9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
spine-c/spine-c/src/spine/Bone.c
View File

@ -166,7 +166,7 @@ void spBone_updateWorldTransformWith(spBone *self, float x, float y, float rotat
zc *= s; zc *= s;
s = SQRT(za * za + zc * zc); s = SQRT(za * za + zc * zc);
if (self->inherit == SP_INHERIT_NOSCALE && if (self->inherit == SP_INHERIT_NOSCALE &&
(pa * pd - pb * pc < 0) != (sx < 0 != sy < 0)) (pa * pd - pb * pc < 0) != ((sx < 0) != (sy < 0)))
s = -s; s = -s;
rotation = PI / 2 + ATAN2(zc, za); rotation = PI / 2 + ATAN2(zc, za);
float zb = COS(rotation) * s; float zb = COS(rotation) * s;
@ -281,7 +281,7 @@ void spBone_updateAppliedTransform(spBone *self) {
pc *= s; pc *= s;
s = SQRT(pa * pa + pc * pc); s = SQRT(pa * pa + pc * pc);
if (self->inherit == SP_INHERIT_NOSCALE && if (self->inherit == SP_INHERIT_NOSCALE &&
pid < 0 != (self->skeleton->scaleX < 0 != (self->skeleton->scaleY * yDownScale) < 0)) (pid < 0) != ((self->skeleton->scaleX < 0) != ((self->skeleton->scaleY * yDownScale) < 0)))
s = -s; s = -s;
r = PI / 2 + ATAN2(pc, pa); r = PI / 2 + ATAN2(pc, pa);
pb = COS(r) * s; pb = COS(r) * s;