From f2fced8bf8163e58227231be0fe152f3b0d9a691 Mon Sep 17 00:00:00 2001 From: Mario Zechner Date: Sun, 20 Jul 2025 21:35:19 +0200 Subject: [PATCH] Fix logging in various Bash scripts --- formatters/format.sh | 2 -- spine-cpp/tests/test.sh | 4 ++-- tests/generate-serializers.sh | 5 ++--- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/formatters/format.sh b/formatters/format.sh index 3ecfa40ac..f92d78553 100755 --- a/formatters/format.sh +++ b/formatters/format.sh @@ -97,8 +97,6 @@ while [[ $# -gt 0 ]]; do esac done -log_title "Code Formatting" - # Call individual formatter scripts (they handle their own logging) if [ "$FORMAT_CPP" = true ]; then "$dir/format-cpp.sh" diff --git a/spine-cpp/tests/test.sh b/spine-cpp/tests/test.sh index eee469f98..8a5917cf6 100755 --- a/spine-cpp/tests/test.sh +++ b/spine-cpp/tests/test.sh @@ -37,7 +37,7 @@ log_detail "Platform: $(uname)" log_action "Building all variants" if BUILD_OUTPUT=$(./build.sh clean release 2>&1); then - log_ok "Build completed" + log_ok else log_fail "Build failed" log_detail "$BUILD_OUTPUT" @@ -58,7 +58,7 @@ for exe in build/headless-test*; do actual_output=$(echo "$OUTPUT" | head -10) if [ "$actual_output" = "$EXPECTED_OUTPUT" ]; then - log_ok "$exe_name" + log_ok pass_count=$((pass_count + 1)) else log_fail "$exe_name - output mismatch" diff --git a/tests/generate-serializers.sh b/tests/generate-serializers.sh index dea771bb2..94420bb18 100755 --- a/tests/generate-serializers.sh +++ b/tests/generate-serializers.sh @@ -19,9 +19,8 @@ fi if [ ! -d "node_modules" ]; then log_action "Installing dependencies" if npm install > /tmp/npm-install.log 2>&1; then - log_ok "Dependencies installed" + log_ok else - log_fail "npm install failed" log_detail "$(cat /tmp/npm-install.log)" exit 1 fi @@ -57,7 +56,7 @@ fi log_action "Generating C++ SkeletonSerializer" if output=$(npx -y tsx src/generate-cpp-serializer.ts 2>&1); then - log_ok "C++ serializer generated successfully" + log_ok else log_fail "Failed to generate C++ serializer" log_detail "$output"