[godot] Closes #2381, regression in SpineSlot::get_bone()

This commit is contained in:
Mario Zechner 2023-09-22 11:15:21 +02:00
parent 432cb9d8e7
commit fa1fb09cb2
2 changed files with 113 additions and 133 deletions

View File

@ -9,75 +9,63 @@
"request": "launch", "request": "launch",
"name": "debug scene v4", "name": "debug scene v4",
"program": "godot/bin/godot.windows.editor.dev.x86_64.exe", "program": "godot/bin/godot.windows.editor.dev.x86_64.exe",
"args": [ "args": ["--path", "example-v4", "examples/07-slot-node/slot-node.tscn"],
"--path",
"example-v4",
"examples/01-helloworld/helloworld.tscn"
],
"cwd": "${workspaceFolder}", "cwd": "${workspaceFolder}",
"preLaunchTask": "build-v4", "preLaunchTask": "build-v4",
"linux": { "linux": {
"type": "lldb", "type": "lldb",
"request": "launch", "request": "launch",
"name": "debug scene v3", "name": "debug scene v3",
"program": "${workspaceFolder}/godot/bin/godot.linux.editor.dev.x86_64", "program": "${workspaceFolder}/godot/bin/godot.linux.editor.dev.x86_64"
}, },
"osx": { "osx": {
"type": "lldb", "type": "lldb",
"request": "launch", "request": "launch",
"name": "debug scene v3", "name": "debug scene v3",
"program": "${workspaceFolder}/godot/bin/godot.macos.editor.dev.arm64", "program": "${workspaceFolder}/godot/bin/godot.macos.editor.dev.arm64"
}, }
}, },
{ {
"type": "cppvsdbg", "type": "cppvsdbg",
"request": "launch", "request": "launch",
"name": "debug editor v4", "name": "debug editor v4",
"program": "godot/bin/godot.windows.editor.dev.x86_64.exe", "program": "godot/bin/godot.windows.editor.dev.x86_64.exe",
"args": [ "args": ["-e", "--path", "example-v4"],
"-e",
"--path",
"example-v4",
],
"cwd": "${workspaceFolder}", "cwd": "${workspaceFolder}",
"preLaunchTask": "build-v4", "preLaunchTask": "build-v4",
"linux": { "linux": {
"type": "lldb", "type": "lldb",
"request": "launch", "request": "launch",
"name": "debug scene v3", "name": "debug scene v3",
"program": "${workspaceFolder}/godot/bin/godot.linux.editor.dev.x86_64", "program": "${workspaceFolder}/godot/bin/godot.linux.editor.dev.x86_64"
}, },
"osx": { "osx": {
"type": "lldb", "type": "lldb",
"request": "launch", "request": "launch",
"name": "debug scene v3", "name": "debug scene v3",
"program": "${workspaceFolder}/godot/bin/godot.macos.editor.dev.arm64", "program": "${workspaceFolder}/godot/bin/godot.macos.editor.dev.arm64"
}, }
}, },
{ {
"type": "cppvsdbg", "type": "cppvsdbg",
"request": "launch", "request": "launch",
"name": "debug editor v4 c#", "name": "debug editor v4 c#",
"program": "godot/bin/godot.windows.editor.dev.x86_64.mono.exe", "program": "godot/bin/godot.windows.editor.dev.x86_64.mono.exe",
"args": [ "args": ["-e", "--path", "example-v4"],
"-e",
"--path",
"example-v4",
],
"cwd": "${workspaceFolder}", "cwd": "${workspaceFolder}",
"preLaunchTask": "build-v4", "preLaunchTask": "build-v4",
"linux": { "linux": {
"type": "lldb", "type": "lldb",
"request": "launch", "request": "launch",
"name": "debug editor v4", "name": "debug editor v4",
"program": "${workspaceFolder}/godot/bin/godot.linux.editor.dev.x86_64", "program": "${workspaceFolder}/godot/bin/godot.linux.editor.dev.x86_64"
}, },
"osx": { "osx": {
"type": "lldb", "type": "lldb",
"request": "launch", "request": "launch",
"name": "debug editor v4", "name": "debug editor v4",
"program": "${workspaceFolder}/godot/bin/godot.macos.editor.dev.arm64.mono", "program": "${workspaceFolder}/godot/bin/godot.macos.editor.dev.arm64.mono"
}, }
}, },
{ {
"type": "cppvsdbg", "type": "cppvsdbg",
@ -85,49 +73,41 @@
"name": "debug scene v3", "name": "debug scene v3",
"cwd": "${workspaceFolder}", "cwd": "${workspaceFolder}",
"program": "${workspaceFolder}/godot/bin/godot.windows.tools.64.exe", "program": "${workspaceFolder}/godot/bin/godot.windows.tools.64.exe",
"args": [ "args": ["--path", "example", "examples/01-helloworld/helloworld.tscn"],
"--path",
"example",
"examples/01-helloworld/helloworld.tscn"
],
"preLaunchTask": "build-v3", "preLaunchTask": "build-v3",
"linux": { "linux": {
"type": "cppdbg", "type": "cppdbg",
"request": "launch", "request": "launch",
"name": "debug scene v3", "name": "debug scene v3",
"program": "${workspaceFolder}/godot/bin/godot.linux.tools.64", "program": "${workspaceFolder}/godot/bin/godot.linux.tools.64"
}, },
"osx": { "osx": {
"type": "lldb", "type": "lldb",
"request": "launch", "request": "launch",
"name": "debug scene v3", "name": "debug scene v3",
"program": "${workspaceFolder}/godot/bin/godot.osx.tools.64", "program": "${workspaceFolder}/godot/bin/godot.osx.tools.64"
}, }
}, },
{ {
"type": "cppvsdbg", "type": "cppvsdbg",
"request": "launch", "request": "launch",
"name": "debug editor v3", "name": "debug editor v3",
"program": "${workspaceFolder}/godot/bin/godot.windows.tools.64.exe", "program": "${workspaceFolder}/godot/bin/godot.windows.tools.64.exe",
"args": [ "args": ["-e", "--path", "example"],
"-e",
"--path",
"example",
],
"cwd": "${workspaceFolder}", "cwd": "${workspaceFolder}",
"preLaunchTask": "build-v3", "preLaunchTask": "build-v3",
"linux": { "linux": {
"type": "cppdbg", "type": "cppdbg",
"request": "launch", "request": "launch",
"name": "debug editor v3", "name": "debug editor v3",
"program": "${workspaceFolder}/godot/bin/godot.linux.tools.64", "program": "${workspaceFolder}/godot/bin/godot.linux.tools.64"
}, },
"osx": { "osx": {
"type": "lldb", "type": "lldb",
"request": "launch", "request": "launch",
"name": "debug editor v3", "name": "debug editor v3",
"program": "${workspaceFolder}/godot/bin/godot.osx.tools.64", "program": "${workspaceFolder}/godot/bin/godot.osx.tools.64"
}, }
}, }
] ]
} }

View File

@ -73,7 +73,7 @@ Ref<SpineSlotData> SpineSlot::get_data() {
Ref<SpineBone> SpineSlot::get_bone() { Ref<SpineBone> SpineSlot::get_bone() {
SPINE_CHECK(get_spine_object(), nullptr) SPINE_CHECK(get_spine_object(), nullptr)
if (_bone.is_valid()) { if (_bone.is_valid()) {
return _data; return _bone;
} else { } else {
auto &bone = get_spine_object()->getBone(); auto &bone = get_spine_object()->getBone();
Ref<SpineBone> bone_ref(memnew(SpineBone)); Ref<SpineBone> bone_ref(memnew(SpineBone));