UnityMirror/xNode
1
0
Fork 0
mirror of https://github.com/Siccity/xNode.git synced 2025-12-20 09:16:01 +08:00
Code

Fixed edge case where swapping connections connected to the same port would cause a "port is already connected" error

Browse Source
This commit is contained in:
Thor Brigsted 2018-10-26 00:31:53 +02:00
parent 9845a7db0c
commit 0b008c77eb
1 changed files with 20 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
Scripts/NodePort.cs
View File

@ -296,29 +296,28 @@ namespace XNode {
int aConnectionCount = connections.Count; int aConnectionCount = connections.Count;
int bConnectionCount = targetPort.connections.Count; int bConnectionCount = targetPort.connections.Count;
List<NodePort> portConnections = new List<NodePort>();
List<NodePort> targetPortConnections = new List<NodePort>();
// Cache port connections
for (int i = 0; i < aConnectionCount; i++)
portConnections.Add(connections[i].Port);
// Cache target port connections
for (int i = 0; i < bConnectionCount; i++)
targetPortConnections.Add(targetPort.connections[i].Port);
ClearConnections();
targetPort.ClearConnections();
// Add port connections to targetPort
for (int i = 0; i < portConnections.Count; i++)
targetPort.Connect(portConnections[i]);
// Add target port connections to this one // Add target port connections to this one
for (int i = 0; i < aConnectionCount; i++) { for (int i = 0; i < targetPortConnections.Count; i++)
PortConnection connection = connections[i]; Connect(targetPortConnections[i]);
NodePort otherPort = connection.Port;
targetPort.Connect(otherPort);
}
// Add connections to target port
for (int i = 0; i < bConnectionCount; i++) {
PortConnection connection = targetPort.connections[i];
NodePort otherPort = connection.Port;
Connect(otherPort);
}
// Remove starting connections on this port
for (int i = aConnectionCount - 1; i >= 0; i--) {
Disconnect(i);
}
// Remove starting connections on target port
for (int i = bConnectionCount - 1; i >= 0; i--) {
targetPort.Disconnect(i);
}
} }
/// <summary> Copy all connections pointing to a node and add them to this one </summary> /// <summary> Copy all connections pointing to a node and add them to this one </summary>