UnityMirror/xNode
1
0
Fork 0
mirror of https://github.com/Siccity/xNode.git synced 2025-12-20 09:16:01 +08:00
Code

Added overload for RemoveInstancePort. Removed return bool.

Browse Source
This commit is contained in:
Thor 2017-12-19 10:42:48 +01:00
parent 66de07e1a7
commit 247482d555
1 changed files with 17 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
Scripts/Node.cs
View File

@ -47,7 +47,7 @@ namespace XNode {
foreach (NodePort port in Ports) port.VerifyConnections(); foreach (NodePort port in Ports) port.VerifyConnections();
} }
#region Instance Ports #region Instance Ports
/// <summary> Returns input port at index </summary> /// <summary> Returns input port at index </summary>
public NodePort AddInstanceInput(Type type, string fieldName = null) { public NodePort AddInstanceInput(Type type, string fieldName = null) {
return AddInstancePort(type, NodePort.IO.Input, fieldName); return AddInstancePort(type, NodePort.IO.Input, fieldName);
@ -72,16 +72,21 @@ namespace XNode {
return port; return port;
} }
public bool RemoveInstancePort(string fieldName) { /// <summary> Remove an instance port from the node </summary>
NodePort port = GetPort(fieldName); public void RemoveInstancePort(string fieldName) {
if (port == null || port.IsStatic) return false; RemoveInstancePort(GetPort(fieldName));
port.ClearConnections();
ports.Remove(fieldName);
return true;
} }
#endregion
#region Ports /// <summary> Remove an instance port from the node </summary>
public void RemoveInstancePort(NodePort port) {
if (port == null) throw new ArgumentNullException("port");
else if (port.IsStatic) throw new ArgumentException("cannot remove static port");
port.ClearConnections();
ports.Remove(port.fieldName);
}
#endregion
#region Ports
/// <summary> Returns output port which matches fieldName </summary> /// <summary> Returns output port which matches fieldName </summary>
public NodePort GetOutputPort(string fieldName) { public NodePort GetOutputPort(string fieldName) {
NodePort port = GetPort(fieldName); NodePort port = GetPort(fieldName);
@ -105,9 +110,9 @@ namespace XNode {
public bool HasPort(string fieldName) { public bool HasPort(string fieldName) {
return ports.ContainsKey(fieldName); return ports.ContainsKey(fieldName);
} }
#endregion #endregion
#region Inputs/Outputs #region Inputs/Outputs
/// <summary> Return input value for a specified port. Returns fallback value if no ports are connected </summary> /// <summary> Return input value for a specified port. Returns fallback value if no ports are connected </summary>
/// <param name="fieldName">Field name of requested input port</param> /// <param name="fieldName">Field name of requested input port</param>
/// <param name="fallback">If no ports are connected, this value will be returned</param> /// <param name="fallback">If no ports are connected, this value will be returned</param>
@ -132,7 +137,7 @@ namespace XNode {
Debug.LogWarning("No GetValue(NodePort port) override defined for " + GetType()); Debug.LogWarning("No GetValue(NodePort port) override defined for " + GetType());
return null; return null;
} }
#endregion #endregion
/// <summary> Called after a connection between two <see cref="NodePort"/>s is created </summary> /// <summary> Called after a connection between two <see cref="NodePort"/>s is created </summary>
/// <param name="from">Output</param> <param name="to">Input</param> /// <param name="from">Output</param> <param name="to">Input</param>