From 4f65fcefc66e2fb2bf4fb733ae004f4c8d276aec Mon Sep 17 00:00:00 2001 From: Thor Kramer Brigsted Date: Tue, 7 Nov 2017 10:02:58 +0100 Subject: [PATCH] Fixed bug that would cause nodes without static ports to not properly remove old static ports --- Example/Nodes/Editor/DisplayValueEditor.cs | 2 +- Scripts/NodeDataCache.cs | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Example/Nodes/Editor/DisplayValueEditor.cs b/Example/Nodes/Editor/DisplayValueEditor.cs index 1aacab1..c7482c4 100644 --- a/Example/Nodes/Editor/DisplayValueEditor.cs +++ b/Example/Nodes/Editor/DisplayValueEditor.cs @@ -9,7 +9,7 @@ namespace BasicNodes { base.OnBodyGUI(); NodeEditorGUILayout.PortField(target.GetInputPort("input")); object obj = target.GetValue(null); - if (obj != null) EditorGUILayout.LabelField(target.GetValue(null).ToString()); + if (obj != null) EditorGUILayout.LabelField(obj.ToString()); } } } \ No newline at end of file diff --git a/Scripts/NodeDataCache.cs b/Scripts/NodeDataCache.cs index ec9cc8f..d37f31f 100644 --- a/Scripts/NodeDataCache.cs +++ b/Scripts/NodeDataCache.cs @@ -16,9 +16,10 @@ namespace XNode { Dictionary staticPorts = new Dictionary(); System.Type nodeType = node.GetType(); - if (!portDataCache.ContainsKey(nodeType)) return; - for (int i = 0; i < portDataCache[nodeType].Count; i++) { - staticPorts.Add(portDataCache[nodeType][i].fieldName, portDataCache[nodeType][i]); + if (portDataCache.ContainsKey(nodeType)) { + for (int i = 0; i < portDataCache[nodeType].Count; i++) { + staticPorts.Add(portDataCache[nodeType][i].fieldName, portDataCache[nodeType][i]); + } } // Cleanup port dict - Remove nonexisting static ports - update static port types