diff --git a/Scripts/Node.cs b/Scripts/Node.cs index 704e99d..62a2f4a 100644 --- a/Scripts/Node.cs +++ b/Scripts/Node.cs @@ -396,6 +396,8 @@ namespace XNode { public void OnBeforeSerialize() { keys.Clear(); values.Clear(); + keys.Capacity = this.Count; + values.Capacity = this.Count; foreach (KeyValuePair pair in this) { keys.Add(pair.Key); values.Add(pair.Value); @@ -404,6 +406,9 @@ namespace XNode { public void OnAfterDeserialize() { this.Clear(); +#if UNITY_2021_3_OR_NEWER + this.EnsureCapacity(keys.Count); +#endif if (keys.Count != values.Count) throw new System.Exception("there are " + keys.Count + " keys and " + values.Count + " values after deserialization. Make sure that both key and value types are serializable."); diff --git a/Scripts/NodeDataCache.cs b/Scripts/NodeDataCache.cs index 3bc8478..4f4937d 100644 --- a/Scripts/NodeDataCache.cs +++ b/Scripts/NodeDataCache.cs @@ -8,13 +8,24 @@ namespace XNode { public static class NodeDataCache { private static PortDataCache portDataCache; private static Dictionary> formerlySerializedAsCache; + private static Dictionary typeQualifiedNameCache; private static bool Initialized { get { return portDataCache != null; } } + public static string GetTypeQualifiedName(System.Type type) { + if(typeQualifiedNameCache == null) typeQualifiedNameCache = new Dictionary(); + + string name; + if (!typeQualifiedNameCache.TryGetValue(type, out name)) { + name = type.AssemblyQualifiedName; + typeQualifiedNameCache.Add(type, name); + } + return name; + } + /// Update static ports and dynamic ports managed by DynamicPortLists to reflect class fields. public static void UpdatePorts(Node node, Dictionary ports) { if (!Initialized) BuildCache(); - Dictionary staticPorts = new Dictionary(); Dictionary> removedPorts = new Dictionary>(); System.Type nodeType = node.GetType(); @@ -23,17 +34,15 @@ namespace XNode { List dynamicListPorts = new List(); - List typePortCache; - if (portDataCache.TryGetValue(nodeType, out typePortCache)) { - for (int i = 0; i < typePortCache.Count; i++) { - staticPorts.Add(typePortCache[i].fieldName, portDataCache[nodeType][i]); - } - } + Dictionary staticPorts; + if (!portDataCache.TryGetValue(nodeType, out staticPorts)) { + staticPorts = new Dictionary(); + } // Cleanup port dict - Remove nonexisting static ports - update static port types // AND update dynamic ports (albeit only those in lists) too, in order to enforce proper serialisation. // Loop through current node ports - foreach (NodePort port in ports.Values.ToList()) { + foreach (NodePort port in ports.Values.ToArray()) { // If port still exists, check it it has been changed NodePort staticPort; if (staticPorts.TryGetValue(port.fieldName, out staticPort)) { @@ -84,7 +93,7 @@ namespace XNode { foreach (NodePort listPort in dynamicListPorts) { // At this point we know that ports here are dynamic list ports // which have passed name/"backing port" checks, ergo we can proceed more safely. - string backingPortName = listPort.fieldName.Split(' ')[0]; + string backingPortName = listPort.fieldName.Substring(0, listPort.fieldName.IndexOf(' ')); NodePort backingPort = staticPorts[backingPortName]; // Update port constraints. Creating a new port instead will break the editor, mandating the need for setters. @@ -147,6 +156,7 @@ namespace XNode { // The following assemblies, and sub-assemblies (eg. UnityEngine.UI) are skipped case "UnityEditor": case "UnityEngine": + case "Unity": case "System": case "mscorlib": case "Microsoft": @@ -195,8 +205,9 @@ namespace XNode { if (inputAttrib != null && outputAttrib != null) Debug.LogError("Field " + fieldInfo[i].Name + " of type " + nodeType.FullName + " cannot be both input and output."); else { - if (!portDataCache.ContainsKey(nodeType)) portDataCache.Add(nodeType, new List()); - portDataCache[nodeType].Add(new NodePort(fieldInfo[i])); + if (!portDataCache.ContainsKey(nodeType)) portDataCache.Add(nodeType, new Dictionary()); + NodePort port = new NodePort(fieldInfo[i]); + portDataCache[nodeType].Add(port.fieldName, port); } if (formerlySerializedAsAttribute != null) { @@ -210,30 +221,6 @@ namespace XNode { } [System.Serializable] - private class PortDataCache : Dictionary>, ISerializationCallbackReceiver { - [SerializeField] private List keys = new List(); - [SerializeField] private List> values = new List>(); - - // save the dictionary to lists - public void OnBeforeSerialize() { - keys.Clear(); - values.Clear(); - foreach (var pair in this) { - keys.Add(pair.Key); - values.Add(pair.Value); - } - } - - // load dictionary from lists - public void OnAfterDeserialize() { - this.Clear(); - - if (keys.Count != values.Count) - throw new System.Exception(string.Format("there are {0} keys and {1} values after deserialization. Make sure that both key and value types are serializable.")); - - for (int i = 0; i < keys.Count; i++) - this.Add(keys[i], values[i]); - } - } + private class PortDataCache : Dictionary> { } } } diff --git a/Scripts/NodePort.cs b/Scripts/NodePort.cs index 6bcc638..b8656ef 100644 --- a/Scripts/NodePort.cs +++ b/Scripts/NodePort.cs @@ -47,8 +47,9 @@ namespace XNode { return valueType; } set { + if (valueType == value) return; valueType = value; - if (value != null) _typeQualifiedName = value.AssemblyQualifiedName; + if (value != null) _typeQualifiedName = NodeDataCache.GetTypeQualifiedName(value); } } private Type valueType;