diff --git a/Scripts/Editor/NodeEditorBase.cs b/Scripts/Editor/NodeEditorBase.cs
index 14ef5ce..6153326 100644
--- a/Scripts/Editor/NodeEditorBase.cs
+++ b/Scripts/Editor/NodeEditorBase.cs
@@ -2,36 +2,42 @@
using System.Collections;
using System.Collections.Generic;
using System.Reflection;
-using UnityEngine;
using UnityEditor;
+using UnityEngine;
namespace XNodeEditor.Internal {
/// Handles caching of custom editor classes and their target types. Accessible with GetEditor(Type type)
- public class NodeEditorBase where A : Attribute, NodeEditorBase.INodeEditorAttrib where T : NodeEditorBase where K : ScriptableObject {
+ public class NodeEditorBase where A : Attribute, NodeEditorBase.INodeEditorAttrib where T : NodeEditorBase where K : ScriptableObject {
/// Custom editors defined with [CustomNodeEditor]
- private static Dictionary editors;
+ private static Dictionary editorTemplates;
+ private static Dictionary editors = new Dictionary();
public K target;
public SerializedObject serializedObject;
public static T GetEditor(K target) {
if (target == null) return null;
- Type type = target.GetType();
- T editor = GetEditor(type);
- editor.target = target;
- editor.serializedObject = new SerializedObject(target);
- return editor;
+ if (!editors.ContainsKey(target)) {
+ Type type = target.GetType();
+ T editor = GetEditor(type);
+ editors.Add(target, Activator.CreateInstance(editor.GetType()) as T);
+ editors[target].target = target;
+ editors[target].serializedObject = new SerializedObject(target);
+ return editor;
+ }
+ return editors[target];
+
}
private static T GetEditor(Type type) {
if (type == null) return null;
- if (editors == null) CacheCustomEditors();
- if (editors.ContainsKey(type)) return editors[type];
+ if (editorTemplates == null) CacheCustomEditors();
+ if (editorTemplates.ContainsKey(type)) return editorTemplates[type];
//If type isn't found, try base type
return GetEditor(type.BaseType);
}
private static void CacheCustomEditors() {
- editors = new Dictionary();
+ editorTemplates = new Dictionary();
//Get all classes deriving from NodeEditor via reflection
Type[] nodeEditors = XNodeEditor.NodeEditorWindow.GetDerivedTypes(typeof(T));
@@ -40,7 +46,7 @@ namespace XNodeEditor.Internal {
if (attribs == null || attribs.Length == 0) continue;
if (nodeEditors[i].IsAbstract) continue;
A attrib = attribs[0] as A;
- editors.Add(attrib.GetInspectedType(), Activator.CreateInstance(nodeEditors[i]) as T);
+ editorTemplates.Add(attrib.GetInspectedType(), Activator.CreateInstance(nodeEditors[i]) as T);
}
}