diff --git a/Scripts/Editor/NodeEditorBase.cs b/Scripts/Editor/NodeEditorBase.cs index 14ef5ce..8ab610e 100644 --- a/Scripts/Editor/NodeEditorBase.cs +++ b/Scripts/Editor/NodeEditorBase.cs @@ -2,45 +2,52 @@ using System.Collections; using System.Collections.Generic; using System.Reflection; -using UnityEngine; using UnityEditor; +using UnityEngine; namespace XNodeEditor.Internal { /// Handles caching of custom editor classes and their target types. Accessible with GetEditor(Type type) - public class NodeEditorBase where A : Attribute, NodeEditorBase.INodeEditorAttrib where T : NodeEditorBase where K : ScriptableObject { + public class NodeEditorBase where A : Attribute, NodeEditorBase.INodeEditorAttrib where T : NodeEditorBase where K : ScriptableObject { /// Custom editors defined with [CustomNodeEditor] - private static Dictionary editors; + private static Dictionary editorTypes; + private static Dictionary editors = new Dictionary(); public K target; public SerializedObject serializedObject; public static T GetEditor(K target) { if (target == null) return null; - Type type = target.GetType(); - T editor = GetEditor(type); - editor.target = target; - editor.serializedObject = new SerializedObject(target); + if (!editors.ContainsKey(target)) { + Type type = target.GetType(); + Type editorType = GetEditorType(type); + editors.Add(target, Activator.CreateInstance(editorType) as T); + editors[target].target = target; + editors[target].serializedObject = new SerializedObject(target); + } + T editor = editors[target]; + if (editor.target == null) editor.target = target; + if (editor.serializedObject == null) editor.serializedObject = new SerializedObject(target); return editor; } - private static T GetEditor(Type type) { + private static Type GetEditorType(Type type) { if (type == null) return null; - if (editors == null) CacheCustomEditors(); - if (editors.ContainsKey(type)) return editors[type]; + if (editorTypes == null) CacheCustomEditors(); + if (editorTypes.ContainsKey(type)) return editorTypes[type]; //If type isn't found, try base type - return GetEditor(type.BaseType); + return GetEditorType(type.BaseType); } private static void CacheCustomEditors() { - editors = new Dictionary(); + editorTypes = new Dictionary(); //Get all classes deriving from NodeEditor via reflection Type[] nodeEditors = XNodeEditor.NodeEditorWindow.GetDerivedTypes(typeof(T)); for (int i = 0; i < nodeEditors.Length; i++) { + if (nodeEditors[i].IsAbstract) continue; var attribs = nodeEditors[i].GetCustomAttributes(typeof(A), false); if (attribs == null || attribs.Length == 0) continue; - if (nodeEditors[i].IsAbstract) continue; A attrib = attribs[0] as A; - editors.Add(attrib.GetInspectedType(), Activator.CreateInstance(nodeEditors[i]) as T); + editorTypes.Add(attrib.GetInspectedType(), nodeEditors[i]); } }