From d7f5bd2a1a2b5a8735f02d339d4f49271181ce73 Mon Sep 17 00:00:00 2001
From: Thor Brigsted <thorbrigsted@gmail.com>
Date: Mon, 6 May 2019 17:54:43 +0200
Subject: [PATCH] Added obsolete methods to help with upgrading

Relating the Instance port > dynamic port change
---
 Scripts/Editor/NodeEditorGUILayout.cs | 12 +++++++
 Scripts/Node.cs                       | 47 ++++++++++++++++++++++++++-
 2 files changed, 58 insertions(+), 1 deletion(-)

diff --git a/Scripts/Editor/NodeEditorGUILayout.cs b/Scripts/Editor/NodeEditorGUILayout.cs
index 7c4de29..1826107 100644
--- a/Scripts/Editor/NodeEditorGUILayout.cs
+++ b/Scripts/Editor/NodeEditorGUILayout.cs
@@ -254,6 +254,18 @@ namespace XNodeEditor {
             GUI.color = col;
         }
 
+#region Obsolete
+        [Obsolete("Use IsDynamicPortListPort instead")]
+        public static bool IsInstancePortListPort(XNode.NodePort port) {
+            return IsDynamicPortListPort(port);
+        }
+
+        [Obsolete("Use DynamicPortList instead")]
+        public static void InstancePortList(string fieldName, Type type, SerializedObject serializedObject, XNode.NodePort.IO io, XNode.Node.ConnectionType connectionType = XNode.Node.ConnectionType.Multiple, XNode.Node.TypeConstraint typeConstraint = XNode.Node.TypeConstraint.None, Action<ReorderableList> onCreation = null) {
+            DynamicPortList(fieldName, type, serializedObject, io, connectionType, typeConstraint, onCreation);
+        }
+#endregion
+
         /// <summary> Is this port part of a DynamicPortList? </summary>
         public static bool IsDynamicPortListPort(XNode.NodePort port) {
             string[] parts = port.fieldName.Split(' ');
diff --git a/Scripts/Node.cs b/Scripts/Node.cs
index 895abbb..cd86b95 100644
--- a/Scripts/Node.cs
+++ b/Scripts/Node.cs
@@ -51,6 +51,47 @@ namespace XNode {
             Strict,
         }
 
+#region Obsolete
+        [Obsolete("Use DynamicPorts instead")]
+        public IEnumerable<NodePort> InstancePorts { get { return DynamicPorts; } }
+
+        [Obsolete("Use DynamicOutputs instead")]
+        public IEnumerable<NodePort> InstanceOutputs { get { return DynamicOutputs; } }
+
+        [Obsolete("Use DynamicInputs instead")]
+        public IEnumerable<NodePort> InstanceInputs { get { return DynamicInputs; } }
+
+        [Obsolete("Use AddDynamicInput instead")]
+        public NodePort AddInstanceInput(Type type, Node.ConnectionType connectionType = Node.ConnectionType.Multiple, Node.TypeConstraint typeConstraint = TypeConstraint.None, string fieldName = null) {
+            return AddInstanceInput(type, connectionType, typeConstraint, fieldName);
+        }
+
+        [Obsolete("Use AddDynamicOutput instead")]
+        public NodePort AddInstanceOutput(Type type, Node.ConnectionType connectionType = Node.ConnectionType.Multiple, Node.TypeConstraint typeConstraint = TypeConstraint.None, string fieldName = null) {
+            return AddDynamicOutput(type, connectionType, typeConstraint, fieldName);
+        }
+
+        [Obsolete("Use AddDynamicPort instead")]
+        private NodePort AddInstancePort(Type type, NodePort.IO direction, Node.ConnectionType connectionType = Node.ConnectionType.Multiple, Node.TypeConstraint typeConstraint = TypeConstraint.None, string fieldName = null) {
+            return AddDynamicPort(type, direction, connectionType, typeConstraint, fieldName);
+        }
+
+        [Obsolete("Use RemoveDynamicPort instead")]
+        public void RemoveInstancePort(string fieldName) {
+            RemoveDynamicPort(fieldName);
+        }
+
+        [Obsolete("Use RemoveDynamicPort instead")]
+        public void RemoveInstancePort(NodePort port) {
+            RemoveDynamicPort(port);
+        }
+
+        [Obsolete("Use ClearDynamicPorts instead")]
+        public void ClearInstancePorts() {
+            ClearDynamicPorts();
+        }
+#endregion
+
         /// <summary> Iterate over all ports on this node. </summary>
         public IEnumerable<NodePort> Ports { get { foreach (NodePort port in ports.Values) yield return port; } }
         /// <summary> Iterate over all outputs on this node. </summary>
@@ -93,7 +134,7 @@ namespace XNode {
             foreach (NodePort port in Ports) port.VerifyConnections();
         }
 
-#region Instance Ports
+#region Dynamic Ports
         /// <summary> Convenience function. </summary>
         /// <seealso cref="AddInstancePort"/>
         /// <seealso cref="AddInstanceOutput"/>
@@ -223,6 +264,8 @@ namespace XNode {
         public class InputAttribute : Attribute {
             public ShowBackingValue backingValue;
             public ConnectionType connectionType;
+            [Obsolete("Use dynamicPortList instead")]
+            public bool instancePortList { get { return dynamicPortList; } set { dynamicPortList = value; } }
             public bool dynamicPortList;
             public TypeConstraint typeConstraint;
 
@@ -244,6 +287,8 @@ namespace XNode {
         public class OutputAttribute : Attribute {
             public ShowBackingValue backingValue;
             public ConnectionType connectionType;
+            [Obsolete("Use dynamicPortList instead")]
+            public bool instancePortList { get { return dynamicPortList; } set { dynamicPortList = value; } }
             public bool dynamicPortList;
 
             /// <summary> Mark a serializable field as an output port. You can access this through <see cref="GetOutputPort(string)"/> </summary>