UnityMirror/spine-runtimes
1
0
Fork 0
mirror of https://github.com/EsotericSoftware/spine-runtimes.git synced 2026-03-26 22:49:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

[unity] Fixed incorrect warnings being issued at unused leftover PMA material keyword. Now when the keyword is unused, no warning is issued. Closes #1856.

Browse Source
This commit is contained in:
Harald Csaszar 2021-03-08 18:09:31 +01:00
parent 2a3d5245d9
commit 055a2d993d
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
spine-unity/Assets/Spine/Runtime/spine-unity/Utility/MaterialChecks.cs
View File

@ -251,8 +251,11 @@ namespace Spine.Unity {
} }
static bool IsPMAMaterial (Material material) { static bool IsPMAMaterial (Material material) {
return (material.HasProperty(STRAIGHT_ALPHA_PARAM_ID) && material.GetInt(STRAIGHT_ALPHA_PARAM_ID) == 0) || bool usesAlphaPremultiplyKeyword = IsSpriteShader(material);
material.IsKeywordEnabled(ALPHAPREMULTIPLY_ON_KEYWORD); if (usesAlphaPremultiplyKeyword)
return material.IsKeywordEnabled(ALPHAPREMULTIPLY_ON_KEYWORD);
else
return material.HasProperty(STRAIGHT_ALPHA_PARAM_ID) && material.GetInt(STRAIGHT_ALPHA_PARAM_ID) == 0;
} }
static bool IsURP3DMaterial (Material material) { static bool IsURP3DMaterial (Material material) {
@ -280,14 +283,18 @@ namespace Spine.Unity {
break; break;
} }
} }
bool isShaderWithMeshNormals = bool isShaderWithMeshNormals = IsSpriteShader(material);
material.shader.name.Contains("Spine/Sprite/Pixel Lit") ||
material.shader.name.Contains("Spine/Sprite/Vertex Lit") ||
material.shader.name.Contains("2D/Spine/Sprite") || // covers both URP and LWRP
material.shader.name.Contains("Pipeline/Spine/Sprite"); // covers both URP and LWRP
return isShaderWithMeshNormals && !anyFixedNormalSet; return isShaderWithMeshNormals && !anyFixedNormalSet;
} }
static bool IsSpriteShader (Material material) {
string shaderName = material.shader.name;
return shaderName.Contains("Spine/Sprite/Pixel Lit") ||
shaderName.Contains("Spine/Sprite/Vertex Lit") ||
shaderName.Contains("2D/Spine/Sprite") || // covers both URP and LWRP
shaderName.Contains("Pipeline/Spine/Sprite"); // covers both URP and LWRP
}
static bool RequiresTintBlack (Material material) { static bool RequiresTintBlack (Material material) {
bool isTintBlackShader = bool isTintBlackShader =
material.shader.name.Contains("Spine") && material.shader.name.Contains("Spine") &&